Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres-analytics/usage): fix project_id filter #4171

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jun 17, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

fixes https://flagsmith.sentry.io/issues/5255763789/?project=5544478&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=14d&stream_index=0
closes #4170

How did you test this code?

Covered by unit test

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 17, 2024 10:55am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 17, 2024 10:55am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 17, 2024 10:55am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jun 17, 2024
@gagantrivedi gagantrivedi requested review from a team and khvn26 and removed request for a team June 17, 2024 10:55
Copy link
Contributor

github-actions bot commented Jun 17, 2024

Uffizzi Preview deployment-53101 was deleted.

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (245ad60) to head (524dfbc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4171   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files        1177     1177           
  Lines       38198    38217   +19     
=======================================
+ Hits        36863    36883   +20     
+ Misses       1335     1334    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 5dafecf Jun 17, 2024
25 checks passed
@gagantrivedi gagantrivedi deleted the fix/4170 branch June 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix project_id filter for organisation usage data on postgres
2 participants