Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logged out of Flagsmith when testing Webhook #2842

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: Logged out of Flagsmith when testing Webhook #2842

merged 1 commit into from
Oct 16, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • When testing a webhook and it returns a 401 error, the user does not log out

How did you test this code?

  • Go to the environment setting page.
  • Click the "Webhook" tab
  • Click the "Create feature webhook" button.
  • Set a URL that returns a 401 error and click the "Test your webhook" button.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 9, 2023 6:11pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Oct 9, 2023 6:11pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Oct 9, 2023 6:11pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/2842

⚙️ Updating now by workflow run 6460280605.

What is Uffizzi? Learn more!

@novakzaballa novakzaballa requested review from a team and khvn26 October 9, 2023 22:38
@novakzaballa novakzaballa merged commit cfbf7f1 into main Oct 16, 2023
15 checks passed
@novakzaballa novakzaballa deleted the fix/logged-out-of-flagsmith-when-testing-webhook branch October 16, 2023 13:56
@novakzaballa novakzaballa linked an issue Oct 16, 2023 that may be closed by this pull request
Logged out of Flagsmith when testing Webhook #2790
Closed
4 tasks
@dabeeeenster dabeeeenster mentioned this pull request Oct 16, 2023
Merged
@novakzaballa novakzaballa mentioned this pull request Oct 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logged out of Flagsmith when testing Webhook
2 participants
@novakzaballa @khvn26