Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run rbac tests with unit on merge to main #2772

Merged
merged 11 commits into from
Nov 15, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Sep 14, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Create a workflow to run tests from private packages like rbac on merge to main

How did you test this code?

here: https://github.com/Flagsmith/flagsmith/actions/runs/6794365166

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 3:52am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 3:52am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 3:52am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Uffizzi Preview deployment-35941 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac26fc9) 95.63% compared to head (ba85813) 95.54%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
- Coverage   95.63%   95.54%   -0.10%     
==========================================
  Files        1012     1013       +1     
  Lines       29139    29331     +192     
==========================================
+ Hits        27868    28025     +157     
- Misses       1271     1306      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi force-pushed the feat/ci/run-rbac-tests branch from e9a615e to f1b234d Compare October 25, 2023 06:03
@gagantrivedi gagantrivedi force-pushed the feat/ci/run-rbac-tests branch from f1b234d to 8642d3c Compare October 25, 2023 06:12
@gagantrivedi
Copy link
Member Author

Depends on #2685

@khvn26
Copy link
Member

khvn26 commented Nov 8, 2023

I think this should modify the original API Unit Tests job, not add a new one.

@gagantrivedi
Copy link
Member Author

gagantrivedi commented Nov 8, 2023

I think this should modify the original API Unit Tests job, not add a new one.

No, we also want to test core without any of these private packages(and don't want it to run on pull request)

@matthewelwell
Copy link
Contributor

I think this should modify the original API Unit Tests job, not add a new one.

No, we also want to test core without any of these private packages(and don't want it to run on pull request)

This is an interesting discussion, yeah. I guess theoretically, the unit tests should be isolated so we should be able to test them in a single workflow, right? The point regarding only running these on a merge to main (or ideally in the merge queue) is a good one though.

@gagantrivedi can you update this to use the merge queue functionality?

@gagantrivedi
Copy link
Member Author

gagantrivedi commented Nov 14, 2023

This is an interesting discussion, yeah. I guess theoretically, the unit tests should be isolated so we should be able to test them in a single workflow, right?

I guess the problem here is that we call all python tests unit tests(in the workflow atleast) maybe we should rename this workflow?

@matthewelwell matthewelwell added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 645f9b1 Nov 15, 2023
18 checks passed
@matthewelwell matthewelwell deleted the feat/ci/run-rbac-tests branch November 15, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants