-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Run rbac tests with unit on merge to main #2772
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
3a33c7b
to
f42e6b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
==========================================
- Coverage 95.63% 95.54% -0.10%
==========================================
Files 1012 1013 +1
Lines 29139 29331 +192
==========================================
+ Hits 27868 28025 +157
- Misses 1271 1306 +35 ☔ View full report in Codecov by Sentry. |
e9a615e
to
f1b234d
Compare
f1b234d
to
8642d3c
Compare
Depends on #2685 |
I think this should modify the original |
No, we also want to test core without any of these private packages(and don't want it to run on pull request) |
This is an interesting discussion, yeah. I guess theoretically, the unit tests should be isolated so we should be able to test them in a single workflow, right? The point regarding only running these on a merge to main (or ideally in the merge queue) is a good one though. @gagantrivedi can you update this to use the merge queue functionality? |
I guess the problem here is that we call all python tests unit tests(in the workflow atleast) maybe we should rename this workflow? |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Create a workflow to run tests from private packages like rbac on merge to main
How did you test this code?
here: https://github.com/Flagsmith/flagsmith/actions/runs/6794365166