Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bulk traits update #45

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

devapro
Copy link
Contributor

@devapro devapro commented Feb 21, 2024

Solution for #34

Copy link
Collaborator

@gazreese gazreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, cheers!

@matthewelwell matthewelwell merged commit 027cc76 into Flagsmith:main Apr 9, 2024
1 check passed
matthewelwell added a commit that referenced this pull request Apr 9, 2024
@matthewelwell
Copy link
Contributor

Hi @devapro, sorry I was too hasty in merging this and realised that this solution will not work in our SaaS environment as the /traits/bulk endpoint does not exist in our Edge API. Can you modify the code to use the /identities endpoint instead which takes a list of traits as an attribute?

POST /api/v1/identities

 + request {
    "identifier": "foo",
    "traits": [
        {
            "trait_key": "foo",
            "trait_value": "bar"
        }
    ]
}

@devapro
Copy link
Contributor Author

devapro commented Apr 24, 2024

Hi @matthewelwell
thanks for the review.
Yes, will create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants