Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ReactNode type #270

Merged
merged 2 commits into from
Dec 18, 2024
Merged

chore: add ReactNode type #270

merged 2 commits into from
Dec 18, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 6, 2024 •
edited
Loading

Replaces React.ReactElement[] | React.ReactElement in favour of React.ReactNode

@kyle-ssg kyle-ssg changed the title Add ReactNode type chore: add ReactNode type Nov 6, 2024
@kyle-ssg kyle-ssg linked an issue Nov 6, 2024 that may be closed by this pull request
Children type should be ReactNode instead of ReactElement #268
Closed
@kyle-ssg kyle-ssg merged commit 8417a31 into main Dec 18, 2024
1 check passed
@kyle-ssg kyle-ssg deleted the chore/adjust-react-node-types branch December 18, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Children type should be ReactNode instead of ReactElement
2 participants
@kyle-ssg @matthewelwell