feat: SSE / real time flags support #32 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he decoding and logic
…nnection logic to use a backoff timer
Bump version 3.7.0 (Flagsmith#66)
…smith-ios-client-sdk into feature/sse-support
Co-authored-by: Matthew Elwell <[email protected]>
matthewelwell
approved these changes
Oct 10, 2024
# Conflicts: # Example/FlagsmithClient/Base.lproj/LaunchScreen.xib # FlagsmithClient/Classes/Traits.swift
As above, there isn't actually a bump |
matthewelwell
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Real Time Flags feature #32 and part of Flagsmith/flagsmith#1498 for iOS.
The functionality is implemented using the Kotlin SDK's implementation as a working example, as this is the platform most closely aligned with the iOS implementation.
One difference of note is that the iOS SDK does not make use of any HTTP client library, using URLSession directly. As such its SSE implementation contains some lower-level functionality not found in the other implementations such as more granular error handling and increasing delay timer on most error conditions.
It also felt prudent to update the Example app to support SwiftUI and in-turn provide a reactive view of the current flags based on the new
var flagStream: AsyncStream<[Flag]>provided by the SDK. This allowed for 'real life' manual testing through various network conditions to verify the integrity of the SSE connection.Pre-iOS 13 compatibility has been maintained as was done in the current SDK, though the need for this is probably up for discussion. Validating the SDK on iOS 12.x wasn't possible on my Mac. The implementation might have been a little tidier it this wasn't the case, and obvious improvements are commented in the code.
Unit tests have been added for all core business logic where possible without butchering the implementation. Significant changes would be required to get any more coverage really.
Regression Test Recommendations
I've tested this on Swift 5.10 and the new Xcode with Swift 6 and everything was fine. Xcode is really good at telling you about deprecations and compatibility issues and there are no warnings.
Has all been linted and formatted.
Would be nice to try this on iOS 12.x if possible.
Type of Change