feat: add file handler option for logging #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
gagantrivedi
and removed request for
a team
gagantrivedi
requested changes
Jun 17, 2024
| @@ -79,7 +79,16 @@ def setup_logging(settings: LoggingSettings) -> None: | |||
| ], | |||
| ) | |||
|
|
|||
| handler = logging.StreamHandler() | |||
| handler_kwargs = {} | |||
There was a problem hiding this comment.
Should we add some tests for this
|
I feel this caters for a too specific problem. I'd spend a bit more time and try to incorporate |
|
Superseded by #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to log to a file.
Overall I'm pretty unhappy adding this behaviour but a specific customer needs it.