Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test for config backwards compatibility #109

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

matthewelwell
Copy link
Contributor

Fixes #108

@khvn26 khvn26 force-pushed the fix/config-is-not-backwards-compatible branch from 3bbf1af to 1b015ae Compare May 20, 2024 15:45
@khvn26 khvn26 changed the base branch from main to feat/identities-local-eval May 20, 2024 15:57
@khvn26 khvn26 force-pushed the fix/config-is-not-backwards-compatible branch 2 times, most recently from 9ba5e29 to e770440 Compare May 20, 2024 16:07
@khvn26 khvn26 force-pushed the feat/identities-local-eval branch 2 times, most recently from d6e99f6 to 8f57884 Compare May 20, 2024 16:13
@khvn26 khvn26 force-pushed the fix/config-is-not-backwards-compatible branch from e770440 to b012839 Compare May 20, 2024 16:14
@khvn26 khvn26 force-pushed the feat/identities-local-eval branch from 8f57884 to 6f26a74 Compare May 21, 2024 09:35
@khvn26 khvn26 requested a review from gagantrivedi May 29, 2024 11:10
@matthewelwell matthewelwell changed the title fix: config is not backwards compatible (WIP) fix: config is not backwards compatible May 29, 2024
@gagantrivedi
Copy link
Member

Fixes #108

The description and title needs updating, right?

Base automatically changed from feat/identities-local-eval to main June 14, 2024 18:56
khvn26 and others added 4 commits June 16, 2024 12:48
 - Bump flag-engine, pydantic
 - Store identity overrides by identifier in the cache
 - Better names for `api_poll_frequency`, `api_poll_timeout`
 - Typing improvements
@khvn26 khvn26 force-pushed the fix/config-is-not-backwards-compatible branch from b012839 to 3355d93 Compare June 16, 2024 11:48
@khvn26 khvn26 changed the title fix: config is not backwards compatible chore: Add test for config backwards compatibility Jun 16, 2024
@khvn26 khvn26 merged commit 9321149 into main Jun 16, 2024
2 checks passed
@khvn26 khvn26 deleted the fix/config-is-not-backwards-compatible branch June 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using default configuration
3 participants