remove sse (#83)

Remove SSE
Flagsmith · Feb 27, 2024 · 4d7f892 · 4d7f892
1 parent 71f547f
commit 4d7f892
Show file tree

Hide file tree

Showing 15 changed files with 4 additions and 492 deletions.
diff --git a/.github/actions/sse-deploy-ecs/action.yml b/.github/actions/sse-deploy-ecs/action.yml
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -3,7 +3,7 @@ name: Pull Request
 on:
     push:
         branches:
-            - main #todo - remove
+            - main
     pull_request:
         types: [opened, synchronize, reopened, ready_for_review]
 
@@ -17,11 +17,6 @@ jobs:
             FLAGSMITH_API_TOKEN: test_token
             ENVIRONMENT_API_KEYS: placeholder_key1
 
-        services:
-          redis:
-            image: redis:7.0.7
-            ports: ["6379:6379"]
-
         strategy:
             max-parallel: 4
             matrix:

diff --git a/.github/workflows/sse-deploy-production-ecs.yml b/.github/workflows/sse-deploy-production-ecs.yml
diff --git a/.github/workflows/sse-deploy-staging-ecs.yml b/.github/workflows/sse-deploy-staging-ecs.yml
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -47,14 +47,3 @@ cd load-test
 wrk -t10 -c40 -d5 -s post.lua -H 'X-Environment-Key: NC7zfaBWg7QJhbHpUMs7tv' 'http://localhost:8001/api/v1/identities/?identifier=development_user_123456'
 ```
 
-# Realtime(SSE)
-
-## Development
-
-### Requirement:
-* Redis: In order to run the test please make sure environment variables `REDIS_HOST`(default: localhost) and `REDIS_PORT`(default:6379) are set correctly
-
-
-
-
-
diff --git a/infrastructure/aws/production/ecs-task-definition-sse.json b/infrastructure/aws/production/ecs-task-definition-sse.json
diff --git a/infrastructure/aws/staging/ecs-task-definition-sse.json b/infrastructure/aws/staging/ecs-task-definition-sse.json
diff --git a/pyproject.toml b/pyproject.toml
@@ -28,3 +28,4 @@ use_parentheses=true
 multi_line_output=3
 include_trailing_comma=true
 line_length=79
+known_first_party=['fastapi_utils']
diff --git a/requirements.in b/requirements.in
@@ -7,7 +7,3 @@ python-dotenv
 pydantic
 orjson
 httpx
-# sse-stuff
-sse-starlette
-asyncio
-redis
diff --git a/requirements.txt b/requirements.txt
@@ -9,8 +9,6 @@ anyio==3.7.1
     #   fastapi
     #   httpcore
     #   starlette
-asyncio==3.4.3
-    # via -r requirements.in
 certifi==2023.7.22
     # via
     #   httpcore
@@ -51,22 +49,16 @@ python-decouple==3.8
     # via -r requirements.in
 python-dotenv==1.0.0
     # via -r requirements.in
-redis==5.0.1
-    # via -r requirements.in
 semver==2.13.0
     # via flagsmith-flag-engine
 sniffio==1.3.0
     # via
     #   anyio
     #   httpcore
     #   httpx
-sse-starlette==1.6.5
-    # via -r requirements.in
 starlette==0.27.0
-    # via
-    #   fastapi
-    #   sse-starlette
-typing-extensions==4.9.0
+    # via fastapi
+typing-extensions==4.8.0
     # via
     #   fastapi
     #   pydantic

diff --git a/src/main.py b/src/main.py
@@ -15,7 +15,6 @@
 from .exceptions import FlagsmithUnknownKeyError
 from .models import IdentityWithTraits
 from .settings import Settings
-from .sse import router as sse_router
 
 app = FastAPI()
 settings = Settings()
@@ -80,4 +79,3 @@ async def refresh_cache():
     allow_headers=["*"],
 )
 app.add_middleware(GZipMiddleware, minimum_size=1000)
-app.include_router(sse_router)
diff --git a/src/settings.py b/src/settings.py
@@ -36,17 +36,8 @@ class Settings(BaseSettings):
     api_url: HttpUrl = "https://edge.api.flagsmith.com/api/v1"
     api_poll_frequency: int = 10  # minutes
     api_poll_timeout: int = 5  # seconds
-
     endpoint_caches: EndpointCachesSettings | None = None
-
-    # sse settings
-    stream_delay: int = 1  # seconds
-    retry_timeout: int = 15000  # milliseconds
-    max_stream_age: int = 30  # seconds
     allow_origins: List[str] = ["*"]
-    sse_authentication_token: str = ""
-    redis_host: str = "localhost"
-    redis_port: int = 6379
 
     class Config:
         @classmethod