Referees 2018/table styling #36
Conversation
modules/sprite.js
Outdated
| @@ -40,19 +44,52 @@ displaySystem.registerModule({ | |||
| function addSprite(config) { | |||
| let sprite = document.createElement('div'); | |||
| sprite.className = 'sprite'; | |||
| sprite.innerHTML = config.html || ''; | |||
| var imageServer = "http://".concat(window.location.hostname).concat(":1395/"); | |||
There was a problem hiding this comment.
This is far too specific (hardcoded ports). Just use a full url in the config
There was a problem hiding this comment.
Also, don't use concat, use string templates or the "+" combinator
modules/sprite.js
Outdated
| var imgSrc = imageServer.concat(config.alias); | ||
|
|
||
|
|
||
| var img = document.createElement('img'); |
There was a problem hiding this comment.
The idea of sprites is that they can take generic html. This is far too specific around images
modules/sprite.js
Outdated
| } | ||
| function setText(configText) { | ||
| texts.forEach(removeSprite); | ||
| addTextsToArray(configText); |
There was a problem hiding this comment.
this function does not exist
|
I really like the effort put into proper formatting, however, as they are interspersed with actual functional commits, it makes them very hard to review. Instead, please supply formatting updates as a separate pull request. Make it explicit in the commits and the pr that there are no functional changes and the update is just about formatting |
config.js
Outdated
| ], | ||
| timer: 10000, | ||
| lines: 8 | ||
| }, | ||
| 'css': { | ||
| href: [ | ||
| 'themes/rednblue-plus/rednblue-plus.css', | ||
| 'themes/fll/flltable.css', |
config.js
Outdated
| textAlign: 'center', | ||
| color: 'rgba(255,255,255,0.5)', | ||
| html: 'FIRST LEGO League' | ||
| side: 'top', |
There was a problem hiding this comment.
These are too specific for one tournament, I'd like to keep the default configuration lightweight and ready-to-go
themes/fll/flltable.css
Outdated
| @@ -0,0 +1,489 @@ | |||
| @import url('fonts/benchnine/benchnine.css'); | |||
There was a problem hiding this comment.
This does not work as the font is not there. Also, this styling is visually quite simalar to rednblue-plus, why not add table styling there?
There was a problem hiding this comment.
The original idea was to have an FLL theme and a more general default theme, with rednblue-plus being the latter. flltable.css is simply a copy-paste of rednblue-plus, with some FLL related things added in (for dealing with the specific sizes of the FLL related sprite images). That line is not needed in flltable.css, but was just copied over along with the rest of rednblue-plus.css ...
config.js
Outdated
| ], | ||
| timer: 5000, | ||
| lines: 8 | ||
| lines: 12 |
There was a problem hiding this comment.
12 lines don't fit with the lower third visible
|
This last commit was by mistake. |
new styling for table.