Adding a setting that allows to remember the config in local storage (or not) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defaults to false, to allow the online version to keep always working, but can be set to true locally to not have to update the config every time
poelstra
approved these changes
Sep 16, 2017
|
FYI, issue created: #26. |
poelstra
requested changes
Sep 16, 2017
There was a problem hiding this comment.
Discussed this offline a bit more: although this now does allow easier local development and handling (incompatible) code changes, it does make it harder for people using e.g. the hosted version to make (persisting) changes to their config.
Given that the idea is to fix this another way (e.g. a version id in config), and that it isn't possible for people to change the server config of the hosted version, I think it may actually be better to think this through a bit more first.
|
Created an issue #27 to discuss this a bit more |
|
Irrelevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to false, to allow the online version to keep always working, but can be set to true locally to not have to update the config every time