-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Referees 2018/generic files #19
Referees 2018/generic files #19
Conversation
I won't merge it like this, although the idea is good. Clock is a very simple application that should work by just opening the index.html from a file system, without any server. In fact, it is used as such in schools, sports clubs and also as a timer for FLL judging. Your changes makes it all dependent on a server. This is not a bad thing, as long as it does not break the ability to work from a file system, which it does. So, in the very least, the $http communication should be more robust and degrade gracefully. I can also see a road in which a custom mp3 is included in the mp3 folder and specified in the config file. |
There are also some general problems with the implementation
|
Also, maybe you can have a look at #13 ? Maybe also #4, but I'm not sure how that would fit the current approach. Thinking out loud for some use cases
|
@@ -75,6 +75,18 @@ The following is a command line example on the windows command prompt, which wil | |||
This one will move the clock 10 px in the horizontal direction (to the right) | |||
- `mclient -n clock -t clock:nudge -d "{ ""direction"": ""x"",""amount"":"10" }"` | |||
|
|||
### Selecting mp3 files | |||
In order to get to chose your own background sounds to play during the clock's run, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling: choose
Moved to PR #20 |
In order to give people a better control over the files they can choose to play and when to play them at the background of the clock. See readme part named "Selecting mp3 files" for full explanation.