Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referees 2018/generic files #19

Conversation

idanstark42
Copy link
Member

In order to give people a better control over the files they can choose to play and when to play them at the background of the clock. See readme part named "Selecting mp3 files" for full explanation.

@rikkertkoppes
Copy link
Member

I won't merge it like this, although the idea is good.

Clock is a very simple application that should work by just opening the index.html from a file system, without any server.

In fact, it is used as such in schools, sports clubs and also as a timer for FLL judging. Your changes makes it all dependent on a server. This is not a bad thing, as long as it does not break the ability to work from a file system, which it does.

So, in the very least, the $http communication should be more robust and degrade gracefully. I can also see a road in which a custom mp3 is included in the mp3 folder and specified in the config file.

@rikkertkoppes
Copy link
Member

rikkertkoppes commented Aug 11, 2017

There are also some general problems with the implementation

  • the file track.mp3 needs to be renamed to track_150.mp3 for the default settings to work. This is not user friendly as it has to be renamed every time you change the countdown time (I like the idea of having a generic name for the start and end, track_start.mp3 and track_stop.mp3, as well as optional time-bound files, for example a special extra drum roll at half time or something)
  • the audio does not resume when pausing and resuming the clock
  • the stop track only seems to play for 1 second, rather than its full length (7 seconds)

@rikkertkoppes rikkertkoppes mentioned this pull request Aug 11, 2017
@rikkertkoppes
Copy link
Member

rikkertkoppes commented Aug 11, 2017

Also, maybe you can have a look at #13 ? Maybe also #4, but I'm not sure how that would fit the current approach.

Thinking out loud for some use cases

  • we could want special tracks at start and end (track_start.mp3)
  • we could want special tracks at special positions (track_75.mp3 or track_50p.mp3) the latter would be a percentage of time
  • we could want a start track, followed by a repeating part, then a stop track. (track_start.mp3, track_after_start_loop.mp3, track_stop.mp3). I am totally making this up as I am writing, we might want a nice discussion on slack...). In fact, I'm moving this to over there.

@@ -75,6 +75,18 @@ The following is a command line example on the windows command prompt, which wil
This one will move the clock 10 px in the horizontal direction (to the right)
- `mclient -n clock -t clock:nudge -d "{ ""direction"": ""x"",""amount"":"10" }"`

### Selecting mp3 files
In order to get to chose your own background sounds to play during the clock's run,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: choose

@idanstark42
Copy link
Member Author

Moved to PR #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants