Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query property to _firestoreProps in FirestoreMixin. #303

Closed
wants to merge 3 commits into from
Closed

Add query property to _firestoreProps in FirestoreMixin. #303

wants to merge 3 commits into from

Conversation

merlinnot
Copy link
Contributor

Fixes #302

@merlinnot
Fix an issue with initail binding in FirestoreMixin.
d0a4870 
This change fixes an issue which occurs when observed/bound properties are defined prior to a call of `connectedCallback`. Since _firestoreUpdateBinding method handles null and undefined values correctly, the `if` statement can be safely removed.
@merlinnot merlinnot mentioned this pull request Oct 27, 2017
Open
danbaechtold
danbaechtold suggested changes Nov 26, 2017
View reviewed changes
Copy link

@danbaechtold danbaechtold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug on line 168, here is the fix:
this._firestoreUpdateBinding(name, config);

Tested with the official demo:
/bower_components/polymerfire/demo/firebase-firestore.html

Now the demo works (query will now sort the collection). Thanks a a lot!

@merlinnot merlinnot mentioned this pull request Dec 22, 2017
Open
3 tasks
@merlinnot merlinnot mentioned this pull request Jan 5, 2018
Merged
@merlinnot
Copy link
Contributor Author

@danbaechtold I’ve fixed that in #310, thank you.

Closing in favor of #310

@merlinnot merlinnot closed this Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbaechtold danbaechtold danbaechtold requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merlinnot @danbaechtold