Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: connect and sign from LIFF #17

Closed
wants to merge 3 commits into from
Closed

feat: connect and sign from LIFF #17

wants to merge 3 commits into from
+592 −257

Conversation

shiki-tak
Copy link

@shiki-tak shiki-tak commented Jul 13, 2024 •
edited
Loading

close #16

  • Updated to allow launching of wallet when connecting to wallet from LIFF browser
  • WalletProvider now supports v2
  • Added a button to sign from LIFF browser after connecting to wallet
  • Currently, the PairingMetadata url is set in my test environment, so it will need to be corrected later.
test.mp4

@shiki-tak shiki-tak self-assigned this Jul 13, 2024
@shiki-tak shiki-tak requested review from da1suk8 and Mdaiki0730 July 13, 2024 06:45
@github-actions github-actions bot temporarily deployed to Netlify Preview July 18, 2024 09:55 Inactive
@shiki-tak
Copy link
Author

Since ci fails for PRs from forked branches, we will remake them into the following PRs.
#19

@shiki-tak shiki-tak closed this Jul 18, 2024
This was referenced Jul 18, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mdaiki0730 Mdaiki0730 Mdaiki0730 left review comments

@da1suk8 da1suk8 Awaiting requested review from da1suk8

Assignees

@shiki-tak shiki-tak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a condition to display the Wallet selection screen instead of the QR code when launching from LIFF
2 participants
@shiki-tak @Mdaiki0730