-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load fbridge & fswap store #365
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 50.28% 52.24% +1.95%
==========================================
Files 10 10
Lines 1406 1116 -290
==========================================
- Hits 707 583 -124
+ Misses 654 486 -168
- Partials 45 47 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we test this modifications?
Because there is no unittest.
I've added the test in the PR description. |
* Setup upgrade store loaders * Update CHANGELOG.md (cherry picked from commit 70f49fd)
* Setup upgrade store loaders * Update CHANGELOG.md (cherry picked from commit 70f49fd) Co-authored-by: Youngtaek Yoon <[email protected]>
Description
This patch adds
setupUpgradeStoreLoaders()
, which handles store upgrades.How has this been tested?
fnsad q fswap swaps
Error: Query failed with (111222): runtime error: invalid memory address or nil pointer dereference: panic
Checklist:
CHANGELOG.md