Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to v4 #357

Merged
merged 4 commits into from
May 8, 2024
Merged

feat: upgrade to v4 #357

merged 4 commits into from
May 8, 2024

Conversation

0Tech
Copy link
Contributor

@0Tech 0Tech commented May 8, 2024

Description

This PR upgrades the app version to v4-Marigold.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@0Tech 0Tech self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.31%. Comparing base (de2cd06) to head (11aba00).

❗ Current head 11aba00 differs from pull request most recent head 53257f8. Consider uploading reports for the commit 53257f8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files          10       10           
  Lines        1407     1407           
=======================================
  Hits          708      708           
  Misses        654      654           
  Partials       45       45           
Files Coverage Δ
app/app.go 83.87% <ø> (ø)
app/encoding.go 100.00% <ø> (ø)
cmd/fnsad/cmd/root.go 11.87% <ø> (ø)

@0Tech 0Tech marked this pull request as ready for review May 8, 2024 09:37
@0Tech 0Tech merged commit d239ccf into Finschia:main May 8, 2024
41 checks passed
mergify bot pushed a commit that referenced this pull request May 8, 2024
* Increase go module version

* Update the upgrade name

* Provide github token to get a higher rate limit

* Update CHANGELOG.md

(cherry picked from commit d239ccf)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request May 8, 2024
4 tasks
0Tech added a commit that referenced this pull request May 8, 2024
* Increase go module version

* Update the upgrade name

* Provide github token to get a higher rate limit

* Update CHANGELOG.md

(cherry picked from commit d239ccf)

# Conflicts:
#	CHANGELOG.md

Co-authored-by: Youngtaek Yoon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants