Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stakingplus should implement AppmoduleSimulation to run TestAppStateDeterminism #1265

Closed
wants to merge 3 commits into from
Closed

fix: stakingplus should implement AppmoduleSimulation to run TestAppStateDeterminism #1265

wants to merge 3 commits into from

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Mar 5, 2024 •
edited
Loading

Description

  • stakingplus should implement AppModuleSimulation to run TestAppStateDeterminism
    • Without AppModuleSimulation, make test-sim-nondeterminism is going to fail

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae added A: bug Something isn't working C:x/stakingplus and removed C:x/stakingplus labels Mar 5, 2024
@jaeseung-bae jaeseung-bae self-assigned this Mar 5, 2024
@jaeseung-bae jaeseung-bae marked this pull request as ready for review March 5, 2024 12:00
@jaeseung-bae jaeseung-bae requested a review from a team as a code owner March 5, 2024 12:00
@ulbqb
Copy link
Member

ulbqb commented Mar 7, 2024 •
edited
Loading

make test-sim-nondeterminism
How about add this test to CI?

By the way, the stakingplus module is going to be removed in #1271.

@jaeseung-bae
Copy link
Contributor Author

make test-sim-nondeterminism How about add this test to CI?

By the way, the stakingplus module is going to be removed in #1271.

Yes, It'll be removed.
I'll close this PR, because #1271 is under review.

@jaeseung-bae jaeseung-bae deleted the fix/sim-test-stakingplus branch March 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0Tech 0Tech 0Tech approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

@ulbqb ulbqb Awaiting requested review from ulbqb

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159

Assignees

@jaeseung-bae jaeseung-bae

Labels
A: bug Something isn't working C:x/stakingplus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeseung-bae @ulbqb @0Tech