Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify missing changes of converting to tendermint #1179

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Nov 23, 2023

Description

Modify missing changes of converting to tendermint

related: #1177

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue added the A: bug Something isn't working label Nov 23, 2023
@zemyblue zemyblue self-assigned this Nov 23, 2023
@zemyblue zemyblue added C:x/auth C:x/slashing and removed A: bug Something isn't working labels Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1179 (d235d28) into main (e5fdd7a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   69.74%   69.74%   -0.01%     
==========================================
  Files         643      643              
  Lines       67263    67255       -8     
==========================================
- Hits        46913    46906       -7     
+ Misses      18177    18176       -1     
  Partials     2173     2173              
Files Coverage Δ
x/auth/tx/service.go 70.83% <100.00%> (-1.17%) ⬇️
x/slashing/keeper/hooks.go 69.76% <100.00%> (ø)
x/slashing/keeper/infractions.go 85.00% <100.00%> (-0.15%) ⬇️

... and 1 file with indirect coverage changes

@zemyblue zemyblue added the A: bug Something isn't working label Nov 23, 2023
@zemyblue zemyblue marked this pull request as ready for review November 23, 2023 12:50
tkxkd0159
tkxkd0159 previously approved these changes Nov 27, 2023
0Tech
0Tech previously approved these changes Nov 29, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@zemyblue zemyblue dismissed stale reviews from 0Tech and tkxkd0159 via d235d28 November 30, 2023 01:50
@zemyblue zemyblue requested review from 0Tech and tkxkd0159 November 30, 2023 02:35
@zemyblue zemyblue merged commit a1bab87 into Finschia:main Dec 1, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/auth C:x/slashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants