Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the consensus to CometBFT #1177

Open
1 of 6 tasks
zemyblue opened this issue Nov 16, 2023 · 2 comments
Open
1 of 6 tasks

Change the consensus to CometBFT #1177

zemyblue opened this issue Nov 16, 2023 · 2 comments
Assignees
Labels
A: feature New features

Comments

@zemyblue
Copy link
Member

zemyblue commented Nov 16, 2023

Summary

Let's change the consensus to CometBFT for compatibility with Cosmos-sdk's infra.

Problem Definition

The current finschia-sdk has a different interface and structure from cosmos-sdk, so a lot of time and resources must be invested to apply the good features of the latest cosmos-sdk. However, since the actual efficiency gained compared to this investment is not that great, I think it is a better way to maintain compatibility in the future by directly proposing and contributing the necessary functions to cosmos-sdk.

Therefore, we propose applying Ostracon's main features and useful improvements to cometBFT as in Finschia/cometbft#1, and changing the consensus from Ostracon to cometbft in order to use cometbft in finschia-sdk.

Proposal

Change the consensus from Ostracon to CometBFT.

Pros

  • We can maintain compatibility with cosmos-sdk.
  • It becomes easier to apply the latest cosmos-sdk.

Cons

  • Ostracon’s performance and specialized functions cannot be used.

Todo

  • change the base consensus from ostracon to tendermint (v0.34.24)
  • change the base consensus from tendermint to cometbft (v0.34.27)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue
Copy link
Member Author

If this issue is completed, #674 will be fixed.

@zemyblue
Copy link
Member Author

zemyblue commented Dec 8, 2023

We need to check lbm.base.ostracon.v1.Query.GetBlockResultsByHeight and lbm.base.ostracon.v1.Query.GetBlockByHash of #291 are removed.

This apis are provided in REST api in cosmos-sdk's cometbft api. I think we need to check it later.
https://github.com/cosmos/cosmos-sdk/blob/f6df368d8d45573b99067f0ba87b6d3a5c53128c/client/cometbft.go#L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: feature New features
Projects
None yet
Development

No branches or pull requests

1 participant