Skip to content

style: Improve code quality with new linters #4510

style: Improve code quality with new linters

style: Improve code quality with new linters #4510

Triggered via pull request June 11, 2024 15:28
@tkxkd0159tkxkd0159
synchronize #1414
lint-code
Status Failure
Total duration 4m 36s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
golangci-lint: baseapp/abci.go#L597
missing cases in switch of type codes.Code: codes.OK, codes.Canceled, codes.Unknown, codes.DeadlineExceeded, codes.AlreadyExists, codes.PermissionDenied, codes.ResourceExhausted, codes.Aborted, codes.OutOfRange, codes.Unimplemented, codes.Internal, codes.Unavailable, codes.DataLoss (exhaustive)
golangci-lint: baseapp/abci_test.go#L113
The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
golangci-lint: baseapp/deliver_tx_test.go#L52
The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
golangci-lint: baseapp/deliver_tx_test.go#L97
The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
golangci-lint: baseapp/deliver_tx_test.go#L1312
fmt.Sprintf can be replaced with faster strconv.FormatInt (perfsprint)
golangci-lint: baseapp/deliver_tx_test.go#L1665
fmt.Sprintf can be replaced with faster strconv.Itoa (perfsprint)
golangci-lint: baseapp/deliver_tx_test.go#L1822
The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
golangci-lint: baseapp/grpcrouter_helpers.go#L63
fmt.Errorf can be replaced with errors.New (perfsprint)
golangci-lint: client/broadcast.go#L161
missing cases in switch of type tx.BroadcastMode: tx.BroadcastMode_BROADCAST_MODE_UNSPECIFIED (exhaustive)
golangci-lint: client/cmd_test.go#L97
The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: technote-space/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
golangci-lint
Restore cache failed: Dependencies file is not found in /home/runner/work/finschia-sdk/finschia-sdk. Supported file pattern: go.sum