Skip to content

style: Improve code quality with new linters #4505

style: Improve code quality with new linters

style: Improve code quality with new linters #4505

Triggered via pull request June 11, 2024 02:18
Status Failure
Total duration 6m 36s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 1 warning
golangci-lint
The job running on runner GitHub Actions 1 has exceeded the maximum execution time of 6 minutes.
golangci-lint: crypto/keys/multisig/codec.go#L18
ST1022: comment on exported var AminoCdc should be of the form "AminoCdc ..." (stylecheck)
golangci-lint: crypto/keys/secp256k1/internal/secp256k1/secp256_test.go#L27
SA1019: elliptic.Marshal has been deprecated since Go 1.21: for ECDH, use the crypto/ecdh package. This function returns an encoding equivalent to that of PublicKey.Bytes in crypto/ecdh. (staticcheck)
golangci-lint: crypto/keys/secp256k1/internal/secp256k1/secp256_test.go#L53
test helper function should start from t.Helper() (thelper)
golangci-lint: crypto/keys/secp256k1/internal/secp256k1/secp256_test.go#L150
test helper function should start from t.Helper() (thelper)
golangci-lint: crypto/keys/secp256k1/internal/secp256k1/secp256_test.go#L228
Error return value is not checked (errcheck)
golangci-lint: crypto/keys/secp256k1/internal/secp256k1/secp256_test.go#L239
Error return value is not checked (errcheck)
golangci-lint: server/grpc/gogoreflection/fix_registration.go#L11
directive `// nolint: staticcheck` is unused for linter "staticcheck" (nolintlint)
golangci-lint
issues found
golangci-lint
Restore cache failed: Dependencies file is not found in /home/runner/work/finschia-sdk/finschia-sdk. Supported file pattern: go.sum