Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add npm build to readme.md #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Jan 12, 2024

To run scripts/finschia/init.sh, module @finschia/finschia is required. So, it is necesary to run npm build.

Checklist:

  • I have added a relevant changelog to CHANGELOG.md. (not needed)
  • I have added tests to cover my changes. (not needed)
  • I have updated the documentation accordingly. (not needed)

To run scripts/finschia/init.sh, module `@finschia/finschia` is required.
So, it is necesary to run `npm build`.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Kynea0b Kynea0b requested a review from zemyblue January 12, 2024 08:50
@Kynea0b Kynea0b self-assigned this Jan 12, 2024
@@ -4,6 +4,10 @@

Run the following:

```npm
npm run build
Copy link
Member

@zemyblue zemyblue Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to yarn install & yarn build.
Because finschia-js use yarn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants