Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify license #4

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Modify license #4

wants to merge 7 commits into from

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Jan 22, 2024

close: #3

I didn't find a license of cw-minimal-template. What should I do?

@ulbqb ulbqb marked this pull request as ready for review January 23, 2024 03:11
@ulbqb ulbqb requested review from zemyblue and 170210 January 23, 2024 03:11
@170210
Copy link

170210 commented Jan 23, 2024

@ulbqb
Copy link
Member Author

ulbqb commented Jan 23, 2024

@ulbqb
Copy link
Member Author

ulbqb commented Jan 23, 2024

@170210
It is just the explanation of the license and it doesn't mean that the license is applied to osmosis's work.

https://github.com/osmosis-labs/cw-minimal-template/blob/2c05d77b0c8fd0f44cc5c35f971263bc4b8e6419/LICENSE#L179-L202
This is the way to apply the license. I think it needs a copyright.

@ulbqb ulbqb self-assigned this Jan 23, 2024
@ulbqb ulbqb requested a review from zemyblue February 22, 2024 06:05
@ulbqb
Copy link
Member Author

ulbqb commented Feb 22, 2024

@zemyblue
I modified NOTICE based on advice from the person in charge.

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this license notice is not need. Because this notice file is used by template notice and that notice file is belong users and I think it is user's duty not ours.

@ulbqb ulbqb requested a review from zemyblue February 27, 2024 03:29
@ulbqb
Copy link
Member Author

ulbqb commented Feb 27, 2024

@zemyblue
This project is ours so I think our NOTICE is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license
3 participants