feat: introduce o-spacing to o-private-foundation #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: introduce o-private-foundation * feat: introduce o-private-foundation * backstage: Add Sass token target * backstage: Delete oPrivateFoundation mixin use, as it does not exist --------- Co-authored-by: Lee Moody <[email protected]>
We decided to develop using traditional demos for this package, as the dev experience is better with Sass. We do not expect users to use this package
frshwtr
force-pushed
the
2025-release-o-spacing
branch
from
5bfd9bc to
729cba1
Compare
notlee
reviewed
Nov 13, 2024
|
|
||
| /// All space names supported by o-spacing. | ||
| /// @type Map | ||
| $o-spacing-names: map-keys($_o-spacing-sizes); |
There was a problem hiding this comment.
Variables also need to be renamed to avoid conflicts
* feat: introduce o-private-foundation * feat: introduce o-normalise to o-private-foundation * feat: use o-private-foundation in origami components * feat: introduce o-private-foundation * feat: introduce o-private-foundation * feat: introduce o-private-foundation * chore: revert stories to use o-normalise * chore: remove unused mixins and prefix remaining with private * feat: use o-private-foundation's o-normalise * fix: fix broken imports * fix: fix buttons * chore: use private foundation normalise * chore: revert typography and buttons changes * chore: correct errors * chore: update package-lock.json * chore: use main scss file * chore: use imports as final approach, include o-colors * chore: ensure private foundation is a peerDependency * chore: remove tsx files * chore: remove further cases of @use * chore: remove unecessary variable * chore: namespace variables * chore: ensure original o-normalise is used in demos --------- Co-authored-by: Lee Moody <[email protected]>
frshwtr
force-pushed
the
2025-release-o-spacing
branch
from
ed9c488 to
ad76564
Compare
Takes o3-button and refactors to work in an o2 world. Slightly odd use of Sass/CSS Custom Properties, with Sass conditionals used to output duplicate CSS Custom Properties which override each other in the same declaration. This was the safest way to reuse o3 styles by effectively replacing class names for Sass if statements. It's also more readable and simple than o2 Sass. Despite duplicating some properties, CSS output and performance will be improved by moving away from the Origami Image Service for coloured icons. Currently supports: - Types - Themes - Sizes - Icons - Icons only Does not yet support: - Custom theme maps Will not support: - Outputting CSS granularly. There are not many buttons left in o2 components, and bundle size is reduced overall as noted above. Other things of note: - `o-private-foundation-get` allows other o2 components to grab tokens directly. - Added Metric2 variable font
frshwtr
force-pushed
the
2025-release-o-spacing
branch
from
d3e43d3 to
b952028
Compare
) * chore: align file structure with confirmed convention * chore: fix lint errors * chore: add private foundation includes to sass lint config * chore: format o-multi-select/main.scss * fix: format files * fix: remove engine property from package.json * chore: remove private-foundations * chore: update normalise path * chore: fix lint rules * chore: fix lint rules
* feat: introduce and use o-private-foundation/o-visual-effects * chore: update package-lock.json * chore: move o-visual-effects, replace broken import
notlee
approved these changes
Nov 26, 2024
frshwtr
force-pushed
the
2025-release-o-spacing
branch
from
3c35689 to
a5c0026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Link to Figma designs
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md