Minor fixes for o3-form component #1855
Conversation
There was a problem hiding this comment.
Excellent work turning this around and great commits 💪 There's a couple of outstanding issues and a few extra small issues I spotted whilst reviewing this PR. I think they're probably small enough to be part of this PR, but feel free to make a note somewhere and either come back to those or make a ticket for later
| checkboxLabel="Show Password" | ||
| /> | ||
| {!disabled && <a href="">Forgot password?</a>} | ||
| {!disabled && <a className='o3-typography-link' href="">Forgot password?</a>} |
There was a problem hiding this comment.
There are multiple showPassword ids on the page which is causing some issues
| sidebar: | ||
| badge: | ||
| text: WIP | ||
| variant: caution |
There was a problem hiding this comment.
I can't select these examples, I think they're missing id/for attributes – is this a required property in TSX?
| @@ -72,11 +72,11 @@ const {sources} = Astro.props; | |||
| text-decoration-line: underline; | |||
There was a problem hiding this comment.
I see there's no focus style here, all: unset; has removed it!
| @@ -1,6 +1,10 @@ | |||
| --- | |||
| title: Error summary | |||
| description: The Error Summary appears on the top of a page after a user submits a form which generates an error. | |||
There was a problem hiding this comment.
I've just noticed, there is no preview of this? I'm sure there was
| {description} | ||
| </span> | ||
| )} | ||
| <legend className={labelClasses.join(' ')}> |
There was a problem hiding this comment.
Sorry another little unrelated issue 😅 I notice inputs are too small because they are not a child of .o3-grid which sets --o3-grid-columns-to-span-width (here). Shall we set a fallback size? Ben did the same for social sign in which is supported to align with forms.
Describe your changes
See commit below for changes