feat: o-header subnav primary link styles #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roberta-M
force-pushed
the
feature/sub-navigation-link-primary-style
branch
from
3974967 to
35f1ef1
Compare
Roberta-M
force-pushed
the
feature/sub-navigation-link-primary-style
branch
from
35f1ef1 to
b34235a
Compare
The App has a requirement to have a sub navigation where link items have 'primary' styles and are capitalised with font weight 600. The navigation also requires the background image to use `paper` colour instead of the current default `white-60`. Esentially we want the sub navigation to look like a primary navigation but still have the scroll behaviour of the sub navigation. This introduces `o-header__subnav--primary` modifier which will provide the required style modifications for background colour and text style. Additionally since the text styles are now being using in two places, I've extracted these out to a `_oHeaderPrimaryLink` mixin.
Roberta-M
force-pushed
the
feature/sub-navigation-link-primary-style
branch
from
b34235a to
d9ca368
Compare
|
@notlee That's a great idea to use a modifier class higher up on the This did also make me question if the App could be using the main navigation markup instead of the sub navigation from o-header. The main issue with that approach is that we don't have the js scroll behaviour on the main navigation, that would be a bigger change to make, so this modifier on sub nav approach feels a bit simpler. |
notlee
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The App has a requirement to have a sub navigation where link items have 'primary' styles and are capitalised with font weight 600. Currently, the
.o-header__nav-link--primaryclass provides these styles for primary navigation links, but no equivalent modifier exists for the sub navigation.o-header__subnav-link.To address this, this introduces.o-header__subnav-link--primarystyle modifier for the sub navigation. Additionally, the shared styles are now extracted into a reusable mixin.Now updated to apply the modifier class directly to
.o-header__subnav--primaryinstead of individually to the child item links. This also includes background colour update to usepapercolour so it is styled more like the main navigation.Issue ticket number and link
Jira ticket: https://financialtimes.atlassian.net/jira/software/c/projects/AT/boards/1853?selectedIssue=AT-6340
Link to Figma designs
Figma: https://www.figma.com/design/qYx7j1N3c2qIjJpknCTyPu/De-Fruiting-the-App-%F0%9F%8D%93?node-id=661-91803&node-type=section&t=xyFXvqn98yEKoayT-0
A few small questions:
.o-header__subnav-link--primarya suitable name for this?Screenshot
.o-header__subnav-link--primarstyle in use within the App Life & Arts navigation:Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md