chore: add log on coral stream raising an error #1293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanSanchezAlcala
force-pushed
the
CI-1837-investigate-coral-issues-in-the-apps
branch
from
b8125d7 to
08404d9
Compare
juanSanchezAlcala
force-pushed
the
CI-1837-investigate-coral-issues-in-the-apps
branch
2 times, most recently
from
5663f77 to
773cbc5
Compare
|
Hey @juanSanchezAlcala, you may also be interested in o-errors to implement this. Sends errors to Sentry. It's an old library and I have no idea if/how it's used by Customer Products 🙈 So, just a suggestion to take a quick look. I have no problem with a custom tracking event |
juanSanchezAlcala
force-pushed
the
CI-1837-investigate-coral-issues-in-the-apps
branch
from
1b906b8 to
4fc79f4
Compare
juanSanchezAlcala
force-pushed
the
CI-1837-investigate-coral-issues-in-the-apps
branch
from
4fc79f4 to
2744355
Compare
|
Closing this as it's been open for a while. Please let me know if you would like to revisit this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initialisation of the client object raise and exception we are not caching it and not logging it. With these changes we track the error in that case.
Why ?
We do this because a lot of users are reporting coral initialisation errors , we need to collect data to support this reports