Skip to content

Commit

Permalink
exometer_report: Fix static subscriber spec with Extra param
Browse files Browse the repository at this point in the history
As per documentation in [1], it is possible to pass an Extra param:
"{select, {MatchPattern, DataPoint, Interval [, Retry [, Extra] ]}}"
Example:
"""
{select, {[{ {['_' | '_'],'_','_'}, [], ['$_']}],
          exometer_report_statsd,
          value,
          1000,
	  true,
          [{report_type, counter}]
	 }
}
"""

Without this patch, exometer_report.erl was failing with log warning
"Incorrect static subscriber spec".

[1] https://github.com/Feuerlabs/exometer_core/tree/master#configuring-static-subscriptions
  • Loading branch information
pespin committed Aug 29, 2024
1 parent f65ec52 commit f9c7abc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/exometer_report.erl
Original file line number Diff line number Diff line change
Expand Up @@ -1731,9 +1731,9 @@ init_subscriber({apply, {M, F, A}}) ->
lists:foreach(fun(Sub) ->
init_subscriber(Sub)
end, apply(M, F, A));
init_subscriber({select, Expr}) when tuple_size(Expr)==3;
tuple_size(Expr)==4;
tuple_size(Expr)==5 ->
init_subscriber({select, Expr}) when tuple_size(Expr)==4;
tuple_size(Expr)==5;
tuple_size(Expr)==6 ->
{Pattern, Reporter, DataPoint, Interval, Retry, Extra} =
case Expr of
{P, R, D, I} -> {P, R, D, I, true, undefined};
Expand All @@ -1750,7 +1750,7 @@ init_subscriber({select, Expr}) when tuple_size(Expr)==3;

init_subscriber(Other) ->
?log(warning, "Incorrect static subscriber spec ~p. "
"Use { Reporter, Metric, DataPoint, Interval [, Extra ]}~n",
"Use { Reporter, Metric, DataPoint [, Interval [, Extra ] ]}~n",
[ Other ]).

get_reporter_status(R) ->
Expand Down

0 comments on commit f9c7abc

Please sign in to comment.