Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover export for non-Grid grid types #1113

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

termi-official
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (e7a671d) to head (f37ed60).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Export/VTK.jl 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e7a671d) and HEAD (f37ed60). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (e7a671d) HEAD (f37ed60)
6 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1113       +/-   ##
==========================================
- Coverage   93.57%   0.00%   -93.58%     
==========================================
  Files          39      39               
  Lines        6071    5995       -76     
==========================================
- Hits         5681       0     -5681     
- Misses        390    5995     +5605     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

I assume you already checked that it works, but if you could add a test using SmallGrid in test_abstractgrid.jl to export some cell data and compare hash with Grid, then that would be great IMO.

Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!

The only possible reason I can see for the codecov fail would be the updated CI on master? Not sure exactly why though, but maybe try merging the master changes into the PR branch before merging the PR?

Edit: I guess this is fixed by #1115, merging that reported getting full coverage again, but this test ran on the previous master, so NVM.

@fredrikekre fredrikekre merged commit 12d7259 into master Dec 2, 2024
14 of 16 checks passed
@fredrikekre fredrikekre deleted the do/grid-export-type branch December 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants