Escape back slashes in shExp2RegExp. Add unit tests. Fix #473.

FelisCatus · May 22, 2015 · 55fba17 · 55fba17
1 parent a80489c
commit 55fba17
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/omega-pac/src/shexp_utils.coffee b/omega-pac/src/shexp_utils.coffee
@@ -1,6 +1,6 @@
 module.exports = exports =
   regExpMetaChars: do ->
-    chars = '''[\^$.|?*+(){}/'''
+    chars = '''\\[\^$.|?*+(){}/'''
     set = {}
     for i in [0...chars.length]
       set[chars.charCodeAt(i)] = true

diff --git a/omega-pac/test/shexp_utils.coffee b/omega-pac/test/shexp_utils.coffee
@@ -13,3 +13,7 @@ describe 'ShexpUtils', ->
     it 'should know the difference between escaped and unescaped slashes', ->
       regex = ShexpUtils.escapeSlash '\\\\/\\/test\\/'
       regex.should.equal '\\\\\\/\\/test\\/'
+  describe '#shExp2RegExp', ->
+    it 'should escape regex meta chars and back slashes', ->
+      regex = ShexpUtils.shExp2RegExp 'this.is|a\\test+'
+      regex.should.equal '^this\\.is\\|a\\\\test\\+$'