Refactoring vault api

src/gotodef.rs

@@ -6,7 +6,7 @@ use crate::vault::Vault;
 
 pub fn goto_definition(vault: &Vault, cursor_position: Position, path: &Path) -> Option<Location> {
     // First, find the link that the cursor is in. Get a links for the file and match the cursor position up to one of them
-    let links = vault.select_links_in_file(&path)?;
+    let links = vault.select_links(Some(&path))?;
     let cursors_link = links.iter().find(|&l| 
         l.range.start.line <= cursor_position.line && 
         l.range.end.line >= cursor_position.line && 

src/vault.rs

@@ -181,9 +181,13 @@ impl Linkable<'_> {
 
 impl Vault {
     /// Select all links ([[Link]]) in a file
-    pub fn select_links_in_file(&self, path: &Path) -> Option<&Vec<Link>> {
-        self.files.get(path).map(|md| &md.links)
-    }
+    pub fn select_links(&self, path: Option<&Path>) -> Option<Vec<&Link>> {
+        match path {
+            Some(path) => self.files.get(path).map(|md| &md.links).map(|vec| vec.iter().collect()),
+            None => Some(self.files.values().flat_map(|md| &md.links).collect())
+        }
+
+    } // TODO: less cloning?
 
     /// Select all linkable positions in the vault
     pub fn select_linkable_nodes<'a>(&'a self) -> Vec<Linkable<'a>> {