Correct the version information, and document what needs to be modifi…

…ed when making changes
Fedict · Dec 13, 2023 · c878aa6 · c878aa6
1 parent 919da6e
commit c878aa6
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 2 deletions.
diff --git a/plugins_tools/eid-viewer/gtk/gtkui.c b/plugins_tools/eid-viewer/gtk/gtkui.c
@@ -61,7 +61,7 @@ void show_cert_image(const char* label, void *data, int len G_GNUC_UNUSED) {
 /* Show an "about" dialog */
 void showabout(GtkWidget* about G_GNUC_UNUSED, gpointer user_data G_GNUC_UNUSED) {
 	GtkWindow* window = GTK_WINDOW(gtk_builder_get_object(builder, "mainwin"));
-	const char *authors[] = { "Wouter Verhelst", "Frederik Vernelen", NULL };
+	const char *authors[] = { "Wouter Verhelst", "Frederik Vernelen", "Thomas Charlier", NULL };
 	const char *artists[] = { "Frank Mariën", NULL };
 	gtk_show_about_dialog(window,
 			"program-name", _("eID Viewer"),

diff --git a/plugins_tools/eid-viewer/xml/eidv4.xsd b/plugins_tools/eid-viewer/xml/eidv4.xsd
@@ -41,7 +41,8 @@
           <xsd:enumeration value="4.1" />
           <xsd:enumeration value="4.2" />
           <xsd:enumeration value="4.3" />
-		  <xsd:enumeration value="4.4" />
+	  <xsd:enumeration value="4.4" />
+	  <xsd:enumeration value="4.5" />
         </xsd:restriction>
       </xsd:simpleType>
     </xsd:attribute>

diff --git a/plugins_tools/eid-viewer/xml/versions.md b/plugins_tools/eid-viewer/xml/versions.md
@@ -44,6 +44,13 @@ New allowed values:
 Version 4.4
 -----------
 
+New attributes:
+
+- `graphpersoversion` for the `&lt;eid&gt;` toplevel element.
+
+Version 4.5
+-----------
+
 New elements:
 
 - `&lt;cardA&gt; child element of the `&lt;card&gt;` element
diff --git a/plugins_tools/eid-viewer/xmlmap.cpp b/plugins_tools/eid-viewer/xmlmap.cpp
@@ -11,6 +11,23 @@ static bool inited = false;
  * label to an element struct. We wrote it in C++ so we can use the STL
  * containers, but other than that C++ isn't really needed... */
 
+
+/****************************************************************************
+ * NOTE NOTE NOTE                                                           *
+ *                                                                          *
+ * When adding new attribute or element mapppings to this file, also        *
+ * update the following files:                                              *
+ *                                                                          *
+ * - plugins_tools/eid-viewer/xml/eidv4.xsd: used for validation on macOS   *
+ *   and Linux. Add the new attributes or elements and the new version.     *
+ * - plugins_tools/util/labels.c: add the elements or attributes, and       *
+ *   tag them with a new version number                                     *
+ * - plugins_tools/eid-viewer/xml/versions.md: document the                 *
+ *   modifications you made.                                                *
+ *                                                                          *
+ * NOTE NOTE NOTE                                                           *
+ ****************************************************************************/
+
 /* Attributes of the <identity> element */
 struct attribute_desc identity_attributes[] = {
 	{TEXT("nationalnumber"), TEXT("national_number"), 1},