Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gas model fixes #460

Merged
merged 3 commits into from
Dec 6, 2024
Merged

fix: gas model fixes #460

merged 3 commits into from
Dec 6, 2024

Conversation

BenSparksCode
Copy link
Contributor

@BenSparksCode BenSparksCode commented Dec 4, 2024 •
edited
Loading

Changes:

  • Lower calldata gas cost estimation to 16 gas per byte (2 hex chars per byte)
  • Increase FIXED_GAS_OFFSET from 85k to 120k gas
  • Lower Atlas gas surcharge from 50% to 5% on Polygon
  • Lower Bundler gas surcharge from 50% to 20% on Polygon

@BenSparksCode BenSparksCode marked this pull request as ready for review December 4, 2024 10:41
jj1980a
jj1980a approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@jj1980a jj1980a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

marshabl
marshabl approved these changes Dec 4, 2024
View reviewed changes
Copy link

@marshabl marshabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0x1NotMe
0x1NotMe approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@0x1NotMe 0x1NotMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenSparksCode BenSparksCode changed the base branch from atlas-v1.1 to atlas-v1.3 December 6, 2024 08:43
@BenSparksCode BenSparksCode changed the title Gas Model Fixes fix: gas model fixes Dec 6, 2024
@BenSparksCode BenSparksCode merged commit 5a44cbe into atlas-v1.3 Dec 6, 2024
2 of 3 checks passed
@BenSparksCode BenSparksCode deleted the gas-model-fixes branch December 6, 2024 08:44
@BenSparksCode BenSparksCode mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jj1980a jj1980a jj1980a approved these changes

@marshabl marshabl marshabl approved these changes

@0x1NotMe 0x1NotMe 0x1NotMe approved these changes

@thogard785 thogard785 Awaiting requested review from thogard785

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenSparksCode @0x1NotMe @marshabl @jj1980a