Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundler gets bundler surcharge if all solvers fail #437

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

BenSparksCode
Copy link
Contributor

@BenSparksCode BenSparksCode commented Sep 25, 2024

Changes:

  • Before:
    • Case: Some solvers, all fail, and when failure is solver's fault:
      • The Atlas and Bundler surcharges were kept as an Atlas surcharge, and the bundler would only receive the base gas cost portion of this solver failure case.
  • After:
    • Case: same as above
      • Atlas only keeps the Atlas surcharge portion of the failing solver gas cost, while the base gas cost and the Bundler surcharge are refunded to the bunder.

Extra changes to also consider in this bundler surcharge accounting category:

@BenSparksCode BenSparksCode marked this pull request as ready for review October 16, 2024 09:31
@BenSparksCode BenSparksCode merged commit 1f17b9d into solver-surcharge-tracking Oct 16, 2024
2 of 3 checks passed
@BenSparksCode BenSparksCode deleted the solver-surcharge-tracking-2 branch October 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants