Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fx dialog positioning #1225

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: fx dialog positioning #1225

merged 1 commit into from
Nov 26, 2024

Conversation

DSCaskey
Copy link
Contributor

This PR fixes the positioning of the fx dialog. It now positions correctly according to the settings in the Preferences. For some reason having the resize() and a call to the position code inside the overriding showEvent() was causing unpredicatable placement of the dialog.

closes issue #1224

@DSCaskey DSCaskey added bug Draft mode UI fixed Fixed in a previous commit or outside of Seamly2D formulas labels Nov 26, 2024
@DSCaskey DSCaskey requested a review from csett86 November 26, 2024 07:08
@DSCaskey DSCaskey self-assigned this Nov 26, 2024
Copy link

what-the-diff bot commented Nov 26, 2024

🌟 Pull Request Overview 🌟

Here's what this fantastic update will bring to our app. Get ready for an even smoother user experience! 🎉

  • Tailor-Made Dialog Size 📏
    We've included an awesome feature to automatically resize the dialog box based on your last saved size whenever it's launched. It's like your software has memory! 💽

  • Remembering Your Favorites 📍
    Now, the dialog box can appear exactly where you'd prefer - the software will remember the spot you like the most! Less dragging around, more working efficiently. 🚀

  • Cleaner Workflow 🧹
    We've wiped away some redundant resize logic in the background. Such a simple, clean, streamlined process benefits us all! 🕹️

  • Ditch the Extra Check ☑️
    We've gotten rid of the isInitialized flag check. Now, the dialog box will apply the size setting every time, no second guessing required. Simplification for the win! 🎁

  • Enhanced Resize Control 🕹️
    The dialog box now includes a more intuitive resize control - a size grip. This means better control and a finer-tuned experience for you! 🎈

So, get ready for these wonderful improvements coming in. We're working hard to make your experience smoother and more tailored for you! After all, it's all about you. Sit back, relax, and enjoy the wonders of technology, where every update is a step towards a better future. 🌈

@DSCaskey DSCaskey merged commit 410a4bf into develop Nov 26, 2024
10 checks passed
@DSCaskey DSCaskey deleted the fix-fx-dialog-positioning branch November 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Draft mode fixed Fixed in a previous commit or outside of Seamly2D formulas UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants