-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix silicon support #111
base: master
Are you sure you want to change the base?
Fix silicon support #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have testing for macos, neither arm or intel.
Could you add this
It should require modifying the .github/workflows/test-python.yml
to use a strategy including the run-on cases
See this ALE example for it - https://github.com/Farama-Foundation/Arcade-Learning-Environment/blob/master/.github/workflows/ci.yml
Could you add to the wheel building workflow to build macos |
Just had to reorder the platform conditionals to fix silicon support