Fix Faraday-Telemetry For Use on Raspberry Pi #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker and main Flask threads have separate connections to the database now. It's a bit messy but should work and does log to database now with my computer. Need to test on Raspberry Pi.
Missed an old conn variable that needed to be updated to queryStationsConn.
Open and close database on every sqlInsert() call. Also found I wasn't properly closing the database prior which might be why stations failed?
Added documentation and removed unnecessary code. Cleaned up a few return False statements too.
Added telemetryWorker catching of False flag when error occurs.
Instead just raise exceptions and let it run it's course. Seems more straightforward.
Removed the rest of the code I commented out to move towards discrete DB connections per thread. I also cleaned up several areas with better/new comments.
Per an error with a locked database on line 960 cur = queryStationsDB.cursor() I moved this into the next try statement to see if it catches better.
Needed to catch a JSON decode error if faraday-telemetry returns bad JSON data on one particular instance. This allows faraday-aprs to continue and obtain new data on next call of getStations().
I never stopped the counter from incrementing and once the value reached 8280 and incremented to 8281 the telemetry suddenly was rejected/ignored by aprs.fi. This led to realizing the counter is limited to this value and I should just reset. Therefore this fix just implements a for loop counting in the infinite while loop which resets to zero after counting to 8179. Yes I stayed one count away from the maximum just incase there is misunderstanding about zero indexing.
|
@reillyeon I just committed cfdee3a which fixes the telemetry sequence bug found on #272! I have it running on my Raspberry Pi now but it will take 8280 * 15 seconds interval = 124,200 seconds = 2,070 minutes = 34.5 hours to find out. This means the counter will get to the rollover point around 9AM Friday morning. I'll leave it running but feel that this is now ready to pull in! |
|
Noting that while not currently running on my RPi (bricked with power cycle) I have been running
|
|
@kb1lqc Please add |
|
@kb1lqd added aprslib to |
kb1lqd
approved these changes
Sep 28, 2017
This was referenced Sep 28, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Faraday-Software #272 and #270 the
faraday-telemetrysoftware did not run on the Raspberry Pi 3. @reillyeon suggested ensuring each thread had it's own database connection which this PR should do. Also, I found that that alone did not work and enabled SQLite3 Write-Ahead Logging (WAL) mode was also required. This prevented slower operations such as opening/closing the .journal file which is not usually an issue but slow enough on the Raspberry Pi to cause database access issues.Changelog
openDB()function to help open up database connection easieropenDB()Testing
Currently the code is running on a Raspberry Pi 3 with September 2017 Raspbian. It is updating KB1LQC-1 on aprs.fi with telemetry data in a duration test at the time of this PR submission.
Also here's a screenshot of the aprs.fi raw telemetry being sent with this branch
faraday-telemetrycode.