Add Codecs to serializable classes #718
Draft
+2,713
−1,866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
q: why do the singleton iotas (null/garbage) go through codec deserialization when they are Codec.unit's cant you just safely assume that the iota is just the unit |
|
Can you rebase this into fewer commits please? Like one commit for the codec implementation, and one commit where you switch everything over to using the new codecs. |
…asset download failures
…he square root of a negative number
…by defaulting all readable items to read NullIota() if no iota contained. Fixed behaviour of OpRead and similar if no IotaHolder found.
…umptionPriority.
…from things with nothing in them), remove references to Hands in places where they aren't needed.
…adding a writeable() method to IotaHolderItem.
…ackets unnecessarily, getting names of patterns for every cast and only using if a mishap occurs)
… enough for that to be fine.
… longer triggering.
….overcast.player" still needs to be defined in ru_ru and zh_cn.
Co-authored-by: [object Object] <[email protected]>
Co-authored-by: [object Object] <[email protected]>
…of hardcoding Control/Command in the book
|
I think we should probably delay this until after the 1.20.1 release. @object-Object I think you had similar thoughts? |
|
yeah, I have the project entry planned for "some future 0.11.x release" currently. I think we discussed it on Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds codecs to serializable classes like Iotas, Continuation Frames, HexPattern, etc. Although codecs are not necessary for 1.20.1, this should help us migrate to future versions more easily.
Changes
All
serialize()anddeserialize()methods in classes with codecs have been marked as deprecated as they should be removed in future versions. The implementations of those methods have also been altered to use codecs.2 new extension functions have been added to
HexUtils.ktto aid with using codecs:<T : Any> T.serializeWithCodec(codec: Codec<T>): Tag?<T : Any> Tag.deserializeWithCodec(codec: Codec<T>): T?All codecs were designed to be backwards compatible, so iotas from previous versions should load correctly.
Entity Iotas have been changed to accommodate codecs:
List<Iota>.getEntityand related functions now require aworldargument