Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include all commits from the year the user joined #223

Merged

Conversation

FajarKim
Copy link
Owner

@FajarKim FajarKim commented Jan 5, 2024

Description

This feature added include all commits from the year the user joined until now.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Misc change (updated other files non-breaking change)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with npm test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

No screenshots

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-profile ✅ Ready (Inspect) Visit Preview Jan 5, 2024 2:43am

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (6bc5040) 49.78% compared to head (ddd48a8) 44.74%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/fetcher/apiFetch.ts 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   49.78%   44.74%   -5.04%     
==========================================
  Files          13       13              
  Lines         231      257      +26     
  Branches       70       73       +3     
==========================================
  Hits          115      115              
- Misses        101      127      +26     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FajarKim FajarKim merged commit fc7489c into master Jan 5, 2024
9 of 11 checks passed
@FajarKim FajarKim deleted the feat_include_all_commits_from_the_year_the_user_joined branch January 5, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant