Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update x position for text and icon if locale is right to left #222

Conversation

FajarKim
Copy link
Owner

@FajarKim FajarKim commented Jan 2, 2024

Description

Update x position for text and icon if locale is right to left

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Misc change (updated other files non-breaking change)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with npm test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

No screenshots

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-profile ✅ Ready (Inspect) Visit Preview Jan 2, 2024 11:32pm

@github-actions github-actions bot added the card label Jan 2, 2024
@FajarKim FajarKim merged commit 67cd0d0 into master Jan 2, 2024
8 checks passed
@FajarKim FajarKim deleted the fix_update_x_position_for_icon_and_text_if_locale_is_right_to_left branch January 2, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant