New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blog post networking code #88

Merged

modmuss50 merged 2 commits into FabricMC:main from kevinthegreat1:1205-fixes

Apr 29, 2024

Contributor

kevinthegreat1 commented Apr 28, 2024

Fixes two mistakes in example code:

Instance should be PacketCodec<> and not PacketCodecs<>.

All play and config networking receivers take payload and context.

Supersedes #87 (renamed branch)


          Fix blog post networking code

d9e0203

VelizarBG commented Apr 28, 2024

I'm pretty sure the table refers to these interfaces, respectively.
https://github.com/FabricMC/fabric/blob/97fc76fd23f24e54ab13644645ae1e350c0bfef3/fabric-networking-api-v1/src/main/java/net/fabricmc/fabric/api/networking/v1/ServerPlayNetworking.java#L326-L337
https://github.com/FabricMC/fabric/blob/97fc76fd23f24e54ab13644645ae1e350c0bfef3/fabric-networking-api-v1/src/client/java/net/fabricmc/fabric/api/client/networking/v1/ClientPlayNetworking.java#L284-L300
https://github.com/FabricMC/fabric/blob/97fc76fd23f24e54ab13644645ae1e350c0bfef3/fabric-networking-api-v1/src/main/java/net/fabricmc/fabric/api/networking/v1/ServerConfigurationNetworking.java#L269-L280
https://github.com/FabricMC/fabric/blob/97fc76fd23f24e54ab13644645ae1e350c0bfef3/fabric-networking-api-v1/src/client/java/net/fabricmc/fabric/api/client/networking/v1/ClientConfigurationNetworking.java#L274-L280


          Fix context fields

de64133

Contributor Author

kevinthegreat1 commented Apr 28, 2024

Fixed, thanks for pointing that out.

apple502j approved these changes

View reviewed changes

modmuss50 approved these changes

View reviewed changes

modmuss50 merged commit 03f4491 into FabricMC:main

2 checks passed

kevinthegreat1 deleted the 1205-fixes branch

April 29, 2024 14:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet