Template fix #102
Merged
Template fix #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octol1ttle
reviewed
Jul 31, 2024
scripts/src/lib/template/templates/entrypoint/Entrypoint.java.eta
Outdated
Show resolved
Hide resolved
|
public static final String MOD_ID = "modid" |
Octol1ttle
suggested changes
Jul 31, 2024
scripts/src/lib/template/templates/entrypoint/Entrypoint.java.eta
Outdated
Show resolved
Hide resolved
|
Shouldn't the MOD_ID be passed to |
|
Fixed In Indentation Test i suppose its needs to be |
|
Can you give me an example to how it should look like ? |
modmuss50
reviewed
Aug 5, 2024
scripts/src/lib/template/templates/entrypoint/Entrypoint.java.eta
Outdated
Show resolved
Hide resolved
|
|
Octol1ttle
suggested changes
Aug 5, 2024
scripts/src/lib/template/templates/entrypoint/Entrypoint.java.eta
Outdated
Show resolved
Hide resolved
modmuss50
approved these changes
Aug 7, 2024
|
@Octol1ttle For Review:D |
|
Ill merge this now, sorry it took me so long ive been busy with other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
im not sure but this might be the fix for it?