Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transformJson mis-encoding. #1181

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix transformJson mis-encoding. #1181

merged 1 commit into from
Sep 30, 2024

Conversation

qyl27
Copy link
Contributor

@qyl27 qyl27 commented Sep 30, 2024

This is a mis-encoding bug, the InputStreamReader uses the system encoding by default.
In most of Windows system installations, it was not UTF-8, for Chinese users, it may be GB18030.
Reading and writing use different encodings, which will cause garbled when injecting access wideners, especially for CJK characters, etc. (Users may write any string in the description field and any of authors fields in fabric.mod.json.)

Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. 👍

@modmuss50 modmuss50 merged commit 4f69924 into FabricMC:dev/1.8 Sep 30, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants