Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagen docs #234

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Datagen docs #234

wants to merge 51 commits into from

Conversation

skycatminepokie
Copy link

@skycatminepokie skycatminepokie commented Dec 24, 2024

To-do list:

  • Setup
  • Tags
  • Language files
  • Advancements
  • Recipes
  • Loot tables (may need help on defining terminology))
  • I think I mentioned Text.literal somewhere, need to find that and change it to Text.of

Likely for someone else to do:

  • Worldgen providers (those exist, right?)
  • Anything else (since I don't know about it)
  • Models (I've gotten a start on blockstates)

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 0fd0d4d
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/676e3c7a0ed7400008d4b76d
😎 Deploy Preview https://deploy-preview-234--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skycatminepokie
Copy link
Author

skycatminepokie commented Dec 24, 2024

I don't know why my commits are unverified, I'll try to figure that out. If you want to check, the ID of the key that GH says it's signed with is the same ID as one of my subkeys, so I have no clue why it's complaining.

@its-miroma its-miroma added new-content A new page or set of pages stage:expansion This should be expanded labels Dec 24, 2024
@its-miroma its-miroma linked an issue Dec 25, 2024 that may be closed by this pull request
@skycatminepokie
Copy link
Author

I'm ready for proofreading and input! Here are the things I know about. Fact checks I'll incorporate, incomplete/missing I'll want help on or leave it for another PR. I'll incorporate other feedback.

Fact check

  • Conditions are evaluated by criteria (Advancements)
  • Conditions has a playerPredicate field. All Conditions should have a player predicate (technically a LootContextPredicate) (Advancements)

Missing

  • Datagen for custom recipe types (Recipes)
  • LootPoolEntrys need more detail (Loot tables)
  • Chest loot needs an example of how to use it or test it. This could come with a screenshot. (Loot tables)
  • Entity loot needs to be done. (Loot tables)

@skycatminepokie skycatminepokie marked this pull request as ready for review December 27, 2024 05:16
@skycatminepokie skycatminepokie requested a review from a team as a code owner December 27, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content A new page or set of pages stage:expansion This should be expanded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer Guides: Datagen
2 participants