Add verbosity and clarification to First Item tutorial page #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more wording to fill in gaps in tutorial
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IMB11
requested changes
Aug 12, 2024
develop/items/first-item.md
Outdated
|
|
||
| To do this, you can add a public static initialize method to your class and call it from your `ModInitializer` class. Currently, this method doesn't need anything inside it. | ||
| ModItems.java |
There was a problem hiding this comment.
If you want to label these code blocks, use h4 headings.
develop/items/first-item.md
Outdated
| @[code transcludeWith=:::1](@/reference/latest/src/main/java/com/example/docs/item/FabricDocsReferenceItems.java) | ||
|
|
||
| Calling a method on a class statically initializes it if it hasn't been previously loaded - this means that all `static` fields are evaluated. This is what this dummy `initialize` method is for. | ||
|
|
||
| With that added, running your mod will now allow you to /give yourself your {mod-id}:suspicious_substance. |
There was a problem hiding this comment.
Wrap templates in `` please. Eg; {mod-id}: suspicious_substance.
You could alternatively have:
Once you've added this method, you can run your mod and use the following command to give you the suspicious substance item;
\`\`\`command
/give @s <mod-id>:suspicious_substance
\`\`\`
Make sure to replace \`<mod-id>\` with your mod's ID!
develop/items/first-item.md
Outdated
| @[code transcludeWith=:::1](@/reference/latest/src/main/java/com/example/docs/item/FabricDocsReferenceItems.java) | ||
|
|
||
| Calling a method on a class statically initializes it if it hasn't been previously loaded - this means that all `static` fields are evaluated. This is what this dummy `initialize` method is for. | ||
|
|
||
| With that added, running your mod will now allow you to /give yourself your {mod-id}:suspicious_substance. | ||
|
|
||
| But it still won't show up when you press 'E', for that, you will need to register the item to an Item Group, described next. |
There was a problem hiding this comment.
Be more specific;
It wont show up within the creative inventory...
Keybinds aren't fixed, especially vanilla ones like Open Inventory
develop/items/first-item.md
Outdated
| @@ -36,18 +39,28 @@ If you want to change your item's stack size, you can use the `maxCount` method | |||
| This will not work if you've marked the item as damageable, as the stack size is always 1 for damageable items to prevent duplication exploits. | |||
| ::: | |||
|
|
|||
| For example, you can create a new "Suspicious Substance" by adding this static field to your ModItems class. | |||
There was a problem hiding this comment.
Suggested change
| For example, you can create a new "Suspicious Substance" by adding this static field to your ModItems class. | |
| In this example, we will create a "Suspicious Substance" item, by adding this static field to your `ModItems` class. |
IMB11
added
improvement
its-miroma
added
stage:verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.