Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align TextFlowExt with future getLayoutInfo #1246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jugen
Copy link
Collaborator

@Jugen Jugen commented Oct 15, 2024

Refactored TextFlowExt to prepare for future API proposed by JavaFX PR openjdk/jfx#1596
by renaming and adding methods in TextFlowLayout to match those proposed for LayoutInfo.

When the proposed API is integrated and available in JavaFX GA the following steps can be taken:

  1. Rename/refactor the TextFlowExt.textLayout() method to getLayoutInfo()
  2. Then delete the TextFlowExt.getLayoutInfo() method and reference field.
  3. Delete TextFlowLayout and TextFlowSpan.

Special thanks to @andy-goryachev-oracle

@andy-goryachev-oracle
Copy link

Thank you @Jugen for verifying early versions of the API! Please keep in mind that the API might also change during the review process. Hope it gets into jfx24, but no guarantees. Feel free to comment in openjdk/jfx#1596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants