Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elevator #3

Merged
merged 13 commits into from
Dec 28, 2024
Merged

Elevator #3

merged 13 commits into from
Dec 28, 2024

Conversation

PotmanNob
Copy link
Contributor

idk what im doing

GreenTomato5
GreenTomato5 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@GreenTomato5 GreenTomato5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No units lib is nasty work

src/main/java/frc/robot/subsystems/Elevator/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/Elevator.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorIO.java Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorIOSim.java Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorIOSim.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Manager/Manager.java Outdated Show resolved Hide resolved
GreenTomato5
GreenTomato5 requested changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@GreenTomato5 GreenTomato5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the changes from before, accidentallly clicked approve

GreenTomato5
GreenTomato5 requested changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@GreenTomato5 GreenTomato5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those who don't know: 😄 😀 🤣

Those who know: 🗿 💀 ☠️

src/main/java/frc/robot/subsystems/Elevator/ElevatorConstants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorConstants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorConstants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorIOSim.java Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorIOSim.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/Elevator.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorIOReal.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorStates.java Outdated Show resolved Hide resolved
@GreenTomato5
Copy link
Collaborator

rookie mistake, 1 failing check

GreenTomato5
GreenTomato5 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@GreenTomato5 GreenTomato5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions and optional changes, merge when you feel like its done

src/main/java/frc/robot/subsystems/Elevator/Elevator.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorConstants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorConstants.java Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Elevator/ElevatorIOSim.java Show resolved Hide resolved
GreenTomato5
GreenTomato5 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@GreenTomato5 GreenTomato5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍🏽 +100 aura

@PotmanNob PotmanNob merged commit c496b13 into main Dec 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreenTomato5 GreenTomato5 GreenTomato5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PotmanNob @GreenTomato5