Added warning message to fetch_table, added fetch_table_bkchin() #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #48
BackwardsFRAM table in chinook databases has a stock_id field that uses a different numbering system than the stock_id field in all other chinook tables.
This means that, for example joining
fetch_table(fram.db, table_name = "BackwardsFRAM")
andfetch_table(fram.db, table_name = "Cohort")
will silently produce a meaningless result when working with a Chinook database.To prevent this, this branch
warn
argument.fetch_table_bkchin()
, which uses fetch_table() but then renames the problematicstock_id
column tobk_stock_id
, and then uses the chinook bkfram lookup table in{framrosetta}
to add in a functionalstock_id
column and the names associated with the bkfram stocks.Example comparison: