VS2022 17.11 / MSVC 1941 CI Fix #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptheywood
force-pushed
the
msvc1711-ci-fix
branch
3 times, most recently
from
7f12a46 to
2bf9c59
Compare
Also moves where CheckCompilerFunctionality is included to ensure it is triggered before CUDA is attempted
Robadob
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS2022 17.11 / MSVC 19.41 include a stdlib change which enforces CUDA >= 12.4 in a static assert (which I can't find a way to ignore during CMake language detection).
This Adds a new warning if this is why cuda hasn't been found, ensures the warning is triggered, and updates CI to not use VS2022 with CUDA < 12.4