Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optional fields for Group simple-cases #208

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add optional fields for Group simple-cases #208

wants to merge 5 commits into from
+40 −2

Conversation

bdc-ehealth
Copy link

grahamegrieve
grahamegrieve reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with package-lock.json?

grahamegrieve
grahamegrieve reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok except for the package-lock files

@bdc-ehealth
Copy link
Author

@grahamegrieve They must have gotten in by accident. I'll remove them.

grahamegrieve
grahamegrieve reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but sadly there's a whole lot of changes in /npm now?

@bdc-ehealth
Copy link
Author

@grahamegrieve , OK, it should be fine now! Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamegrieve grahamegrieve Awaiting requested review from grahamegrieve

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdc-ehealth @grahamegrieve